Jenkins file to build oracle docker image #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyjams
reviewed
Aug 24, 2023
oracle/Dockerfile
Outdated
| COPY yarn.lock . | ||
| RUN cd oracle && yarn remove web3 web3-utils && cd .. | ||
| RUN NOYARNPOSTINSTALL=1 yarn install --frozen-lockfile --production | ||
| RUN cd commons && yarn add [email protected] && cd .. |
There was a problem hiding this comment.
- Is it possible to
yarn upgrade [email protected]instead ofremove&add? - I don't remember, do we need
&& cd ..?
There was a problem hiding this comment.
I'm going to try the point 1 but for 2. since we are working on 2 different package.json file (oracle / commons) I think we need it. But gonna try it as well
There was a problem hiding this comment.
A good approach here might be something like
WORKDIR /bla
RUN bla bla
WORKDIR /blu
RUN blu blu
(?)
There was a problem hiding this comment.
- I just tried
upgradeit does not work, I have the same issue msg of the beginning - Going to implement the WORKDIR thing
oracle/docker-compose.yml
Outdated
| build: | ||
| context: .. | ||
| dockerfile: oracle/Dockerfile | ||
| image : docker-regis.iex.ec/oracle:feature-ef980a52 |
There was a problem hiding this comment.
Maybe
docker-regis.iex.ec/oracle:$ORACLE_TAG
?
zguesmi
reviewed
Aug 24, 2023
jeremyjams
reviewed
Aug 28, 2023
Jenkinsfile
Outdated
| imageprivacy: 'private', | ||
| dockerImageRepositoryName : 'oracle' | ||
| ) | ||
| } |
There was a problem hiding this comment.
Missing end-of-line :)
Same in (oracle/.env.example)
jeremyjams
reviewed
Aug 28, 2023
Co-authored-by: Jérémy James Toussaint <[email protected]>
…ExecBlockchainComputing/tokenbridge into feature/bellecour-build-oracle
jeremyjams
reviewed
Aug 28, 2023
oracle/Dockerfile
Outdated
|
|
||
| WORKDIR /mono/oracle | ||
| RUN [email protected] [email protected] |
There was a problem hiding this comment.
Suggested change
| RUN [email protected] [email protected] | |
| RUN yarn upgrade [email protected] [email protected] |
I think*
jeremyjams
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can find the job jenkins => Token-bridge