Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually update README.md #61

Closed
wants to merge 1 commit into from
Closed

Manually update README.md #61

wants to merge 1 commit into from

Conversation

jlaehne
Copy link
Contributor

@jlaehne jlaehne commented Sep 11, 2024

Manually fix the extension list for the time that the script is not running (kikuchipy not being v2.0 compatible).

Avoid confusion as raised in hyperspy/hyperspy#3427

@hakonanes
Copy link
Contributor

Sounds good. Working on 2.0 compatibility.

@ericpre
Copy link
Member

ericpre commented Sep 11, 2024

The file https://github.com/hyperspy/hyperspy-extensions-list/blob/main/extension_list.txt needs to be updated (remove kikuchipy temporarily) and then run the script as per instructions in https://github.com/hyperspy/hyperspy-extensions-list/blob/main/doc/how_to_add_extension.md#running-the-make_readmepy-script-manually, ans that will update the README.md file.

@jlaehne
Copy link
Contributor Author

jlaehne commented Sep 12, 2024

Running the script results in the following error. It seems that print_known_signal_types() only prints the information and does not return anything ... was there some change?

    table_html = hs.print_known_signal_types()._repr_html_()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute '_repr_html_'

@jlaehne jlaehne closed this Sep 13, 2024
@jlaehne
Copy link
Contributor Author

jlaehne commented Sep 13, 2024

Replaced by #62

@jlaehne jlaehne deleted the jlaehne-patch-1 branch September 13, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants