Added withdrawals and withdrawalsRoot to EthBlock #1922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: push a small change to run pipeline |
|
@JakubDziworski Pipeline is failing, plz fix the PR |
NickSneo
reviewed
Aug 1, 2023
| return result; | ||
| } | ||
|
|
||
| public List<Withdrawal> getWithdrawals() { |
There was a problem hiding this comment.
Move these functions above public boolean equals(Object o) to around line 357
|
@JakubDziworski I need the features from this PR, are you picking this up again, or do I need to? |
|
Fixed by @angusscott in #1947 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
withdrawalsandwithdrawalsRootfields toEthBlockWhere should the reviewer start?
org.web3j.protocol.core.methods.response.EthBlock.javaWhy is it needed?
Two new fields
withdrawalsandwithdrawalsRootwere added to the block as part of eip-4895