W3C: Reworked predicates representation - no mapping #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: artem.ivanov <[email protected]>
…sentation Signed-off-by: artem.ivanov <[email protected]> # Conflicts: # src/data_types/w3c/proof.rs
Signed-off-by: artem.ivanov <[email protected]>
TimoGlastra
approved these changes
Jan 16, 2024
Cargo.toml
Outdated
| @@ -27,7 +27,7 @@ vendored = ["anoncreds-clsignatures/openssl_vendored"] | |||
| w3c = ["base64", "chrono", "rmp-serde"] | |||
|
|
|||
| [dependencies] | |||
| anoncreds-clsignatures = "0.3.0" | |||
| anoncreds-clsignatures = { git = "https://github.com/DSRCorporation/anoncreds-clsignatures-rs.git", branch = "feat/expose-proof-predicates" } | |||
There was a problem hiding this comment.
0.3.1 has been released
Suggested change
| anoncreds-clsignatures = { git = "https://github.com/DSRCorporation/anoncreds-clsignatures-rs.git", branch = "feat/expose-proof-predicates" } | |
| anoncreds-clsignatures = "0.3.1" |
Signed-off-by: artem.ivanov <[email protected]>
Signed-off-by: artem.ivanov <[email protected]>
…sentation-no-mapping
|
Merging for now so we can create a pre-release. @andrewwhitehead if you have any comments, we can addreess them in a follow up pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TimoGlastra @andrewwhitehead @swcurran
This is an alternative implementation for w3c predicate representation as boolean values to using explicit mapping like was done in PR: #302
I feel like it should work and we can close another PR.
anoncreds-clsignaturesrequires passing of predicate name, type, value for doing verification of each cl sub-proof.If we pass a different predicate value, verification will fail.
It can cause an issue when a request contains multiple predicates with the same attribute name. Due to this, we used an explicit mapping.
In proper way, this information (predicate name /type/value) should be taken from the proof request.
But as we do verification for each request attribute/predicate that presentation contains a verifiable credential providing requested data, we can just take
attributes/predicatesfrom inside of sub proof itself at the sub proof verification step .The function to verify requested predicate check the following:
sub_proofcontains sub_proof for the requested predicate (same name, value, type)This PR: depends on this change in CL AnonCreds library: hyperledger/anoncreds-clsignatures-rs#38