Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ephemeral private key for generating ecdh shared key for encryption #88

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

Chengxuan
Copy link
Contributor

@Chengxuan Chengxuan commented Sep 27, 2024

resolves #47

  • update circuits with encryption to accept an additional input (ecdh private key)
  • ECDH shared key is now generated using the additional private key (user is encouraged to use random ephemeral keys to reduce the blast radius of losing private keys) and the receiver's public key
  • the public key of the ephemeral private key used for generating the ecdh shared key is published in the transfer events so the receiver can generate it using its private key.

in PR chain with #83

Copy link
Contributor

@jimthematrix jimthematrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@jimthematrix jimthematrix merged commit 6bb25ac into more-inputs Sep 30, 2024
3 checks passed
@jimthematrix jimthematrix deleted the random-ecdh-key branch September 30, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants