Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract services to allow for re-use #777

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Extract services to allow for re-use #777

wants to merge 4 commits into from

Conversation

alexandrosfilios
Copy link
Contributor

No description provided.

@alexandrosfilios alexandrosfilios mentioned this pull request Nov 11, 2024
Closed
@alexandrosfilios alexandrosfilios changed the title Fix query 2 Extract services to allow for re-use Nov 13, 2024
@alexandrosfilios
Copy link
Contributor Author

Extracted following services to allow for code re-use:

  • TMS normalizer
  • Query tokens, Query spent tokens
  • Network driver

@alexandrosfilios alexandrosfilios marked this pull request as ready for review November 13, 2024 08:40
adecaro
adecaro approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo comment

token/provider.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecaro adecaro adecaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandrosfilios @adecaro