Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use keripy 1.1.21 #77

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Update to use keripy 1.1.21 #77

merged 8 commits into from
Oct 28, 2024

Conversation

jrayback
Copy link
Contributor

Keripy 1.1.21 is currently the latest official version. The project is updated to use this version.

There are a few minor bug fixes as well.

@jrayback jrayback force-pushed the jrayback_241024_update-to-use-keripy-1.1.21 branch from 1b3d94e to 9940644 Compare October 25, 2024 05:27
@jrayback jrayback force-pushed the jrayback_241024_update-to-use-keripy-1.1.21 branch from 9940644 to 56bb365 Compare October 25, 2024 05:37
@jrayback
Copy link
Contributor Author

As far as I can tell, everything works with keripy 1.1.21. I probably missed some things and will happily add to the PR as needed.

@jrayback
Copy link
Contributor Author

One note, I needed to change the label for the weboftrust/keri docker base image from latest to latest-arm64. This was the only way to get the 1.1.20 docker files to run on my macbook. I'm not sure what the implications for that are for developers on other platforms. There may be a larger cross-architecture strategy that needs to be worked out here.

2byrds
2byrds approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jonathan, LGTM

@2byrds
Copy link
Contributor

2byrds commented Oct 25, 2024

@jrayback the merge needs a conflict fix and then I'll process it

@jrayback
Copy link
Contributor Author

@2byrds , looks like pytest is failing. It also seems some of the GitHub actions need to be updated to match the new set of dependencies. Let me fix those before you merge.

@jrayback
Copy link
Contributor Author

@2byrds , pytest is passing now. All checks look good. You can finish evaluating the PR and merge if desirable.

@2byrds 2byrds merged commit e70f0c0 into hyperledger-labs:main Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2byrds 2byrds 2byrds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrayback @2byrds