-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated and polished the "Torii Endpoints" topic #464
Conversation
… in related topics Signed-off-by: yamkovoy <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Torii endpoints now seem to be more structured and detailed. For me, as a developer, it became clearer.
However, there are a lot of inaccurate details as well.
Co-authored-by: 0x009922 <[email protected]> Signed-off-by: yamkovoy <[email protected]>
Signed-off-by: yamkovoy <[email protected]>
Changes
Notes & Questions
|
@yamkovoy, I am totally fine with your questions, and I can see that my comments might look unclear. The configuration sections you have provided are inaccurate primarily because the whole config system is currently under overhaul by me. I do not provide you any information yet about how to document it properly, and ask you just to leave TODO marks so that I can pick it up later and fill the gaps. Thus, it would be totally fine in scope of this PR to leave TODO marks instead of trying to cover configuration topics, IMO. If it would mean to leave the whole Metrics topic empty - so be it. Please wait until I prepare the configuration reference which will be the foundation in future. (#397) |
Co-authored-by: 0x009922 <[email protected]> Signed-off-by: yamkovoy <[email protected]>
Signed-off-by: yamkovoy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
High attention to detail. In some places even a little bit too much (imo), but it's fine.
Changes