Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Remove CanMintUserAssetDefinitions (#460) #461

Closed

Conversation

6r1d
Copy link
Contributor

@6r1d 6r1d commented Jan 8, 2024

Quoting #460,

According to @mversic here,

there is no such thing as CanMintUserAssetDefinitions. You cannot mint asset definitions, but you can mint assets

We may need to update the example code further

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
iroha-2-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 7:51am

@mversic
Copy link
Contributor

mversic commented Jan 8, 2024

CanMintUserAssetDefinitions has been split into CanMintAssetsWithDefinition and CanRegisterAssetsWithDefinition. Please look at smart_contract/executor/src/default/tokens.rs for complete list of available permission tokens

@@ -15,7 +15,6 @@ The following permission tokens are pre-configured in Iroha 2:
| [`CanRemoveKeyValueInUserAssets`](#canremovekeyvalueinuserassets) | Asset | Remove key value |
| [`CanTransferUserAssets`](#cantransferuserassets) | Asset | Transfer |
| [`CanTransferOnlyFixedNumberOfTimesPerPeriod`](#cantransferonlyfixednumberoftimesperperiod) | Asset | Transfer |
| [`CanMintUserAssetDefinitions`](#canmintuserassetdefinitions) | Asset Definition | Mint |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check my comment in the issue. It should be replaced with new tokens

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mversic could you please assign it on me. I've started actualizing this.

@Stukalov-A-M Stukalov-A-M self-assigned this Jan 18, 2024
Stukalov-A-M added a commit to Stukalov-A-M/iroha-2-docs that referenced this pull request Jan 24, 2024
@Stukalov-A-M
Copy link
Contributor

Example updated #467

Stukalov-A-M added a commit to Stukalov-A-M/iroha-2-docs that referenced this pull request Jan 24, 2024
 : Permissions example; Metadata links to permissions updated.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha-2-docs that referenced this pull request Jan 24, 2024
 : Permissions example; Metadata links to permissions updated.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha-2-docs that referenced this pull request Jan 25, 2024
 : Permissions example; Metadata links to permissions updated.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha-2-docs that referenced this pull request Jan 26, 2024
 : Permissions example; Metadata links to permissions updated.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit that referenced this pull request Jan 26, 2024
* ADD: Table of tokens

Signed-off-by: Stukalov-A-M <[email protected]>

* [EDIT] #460,#461,#462 : Permissions example

Signed-off-by: Stukalov-A-M <[email protected]>

* [EDIT] #460,#461,#462 : Permissions example; Metadata links to permissions updated.

Signed-off-by: Stukalov-A-M <[email protected]>

* [EDIT] #460,#461,#462 : Permissions example; Metadata links to permissions updated.

Signed-off-by: Stukalov-A-M <[email protected]>

* [EDIT] #460,#461,#462 : Permissions example; Metadata links to permissions updated.

Signed-off-by: Stukalov-A-M <[email protected]>

* [EDIT] #460,#461,#462 : Permissions example; Metadata links to permissions updated.

Signed-off-by: Stukalov-A-M <[email protected]>

* Update src/guide/blockchain/metadata.md

Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>

* Update src/reference/permissions.md

Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>

* Update src/reference/permissions.md

Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>

* Update src/reference/permissions.md

Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>

---------

Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants