Merge pull request #695 from termi/master

$mol_compare_deep: fix cyclic reference bug with warmed cache

compare/deep/deep.test.tsx

@@ -75,6 +75,26 @@ namespace $ {
 
 		} ,
 
+		'same POJOs with cyclic reference with cache warmup'() {
+			const obj1 = { test: 1, obj3: null as unknown as Object }
+			const obj1_copy = { test: 1, obj3: null as unknown as Object }
+			const obj2 = { test: 2, obj1 }
+			const obj2_copy = { test: 2, obj1: obj1_copy }
+			const obj3 = { test: 3, obj2 }
+			const obj3_copy = { test: 3, obj2: obj2_copy }
+
+			obj1.obj3 = obj3
+			obj1_copy.obj3 = obj3_copy
+
+			// warmup cache
+			$mol_assert_not( $mol_compare_deep( obj1 , {} ) )
+			$mol_assert_not( $mol_compare_deep( obj2 , {} ) )
+			$mol_assert_not( $mol_compare_deep( obj3 , {} ) )
+
+			$mol_assert_ok( $mol_compare_deep( obj3 , obj3_copy ) )
+
+		} ,
+
 		'Date'() {
 			$mol_assert_ok( $mol_compare_deep( new Date( 12345 ) , new Date( 12345 ) ) )
 			$mol_assert_not( $mol_compare_deep( new Date( 12345 ) , new Date( 12346 ) ) )

compare/deep/deep.ts

@@ -36,11 +36,13 @@ namespace $ {
 
 		} else {
 
-			left_cache = new WeakMap< any , boolean >([[ right, true ]])
+			left_cache = new WeakMap< any , boolean >()
 			$mol_compare_deep_cache.set( left , left_cache )
 
 		}
 
+		left_cache.set(right, true);
+
 		let result!: boolean
 
 		try {