Fix/video prop types (#117)

* chore: update types for video and image tag * chore: remove .idea from git * Create sharp-doors-rest.md --------- Co-authored-by: João Pedro Schmitz <[email protected]>
hygraph · Jan 20, 2024 · 86411d2 · 86411d2
1 parent 232e4da
commit 86411d2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/.changeset/sharp-doors-rest.md b/.changeset/sharp-doors-rest.md
@@ -0,0 +1,5 @@
+---
+"@graphcms/rich-text-types": patch
+---
+
+Fix/video prop types
diff --git a/.gitignore b/.gitignore
@@ -8,3 +8,5 @@ package-lock.json
 yarn.lock
 !/yarn.lock
 coverage/
+
+.idea
diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts
@@ -26,6 +26,7 @@ export interface Element {
     | 'iframe'
     | 'embed'
     | 'code-block';
+
   [key: string]: unknown;
 }
 
@@ -78,12 +79,13 @@ export interface LinkElement extends LinkProps, Element {
 }
 
 export interface ImageProps {
+  type: 'image';
   src: string;
   title?: string;
   width?: number;
   height?: number;
   handle?: string;
-  mimeType?: AssetMimeTypes;
+  mimeType?: ImageMimeTypes;
   altText?: string;
 }
 
@@ -93,10 +95,12 @@ export interface ImageElement extends ImageProps, Element {
 
 export interface VideoProps {
   src: string;
+  type: 'video';
   title?: string;
-  width?: number;
-  height?: number;
+  width: number | null;
+  height: number | null;
   handle?: string;
+  mimeType: VideoMimeTypes;
 }
 
 export interface VideoElement extends VideoProps, Element {