Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added TrackerGOTURN (see roadmap) #1210

Closed
wants to merge 23 commits into from

Conversation

diegohce
Copy link
Contributor

added TrackerGOTURN (see roadmap)

Not sure what to do with two model files needed to run the tests.

added TrackerGOTURN (see roadmap)
@diegohce
Copy link
Contributor Author

diegohce commented Aug 29, 2024

missing files can be downloaded from here

https://github.com/opencv/opencv_extra/tree/c4219d5eb3105ed8e634278fad312a1a8d2c182d/testdata/tracking

for me, for the tests to work they had to be placed on the project's root dir.

@diegohce
Copy link
Contributor Author

I have been experimenting in another repo with this https://git-lfs.com/

and it works like a charm.

Tried to push an experimental branch to my fork with that, but it didn't work as expected (maybe because is a fork? I don't know).

@deadprogram
Copy link
Member

You probably want to look at https://github.com/hybridgroup/gocv/blob/dev/.github/workflows/linux.yml#L21-L29 for an example of how this sort of thing is being done currently.

@diegohce
Copy link
Contributor Author

diegohce commented Sep 1, 2024

You probably want to look at https://github.com/hybridgroup/gocv/blob/dev/.github/workflows/linux.yml#L21-L29 for an example of how this sort of thing is being done currently.

I'll take a look. Thanks!

@diegohce
Copy link
Contributor Author

diegohce commented Sep 1, 2024

I'm sorry, Windows action is beyond my capabilities.

diegohce and others added 14 commits September 3, 2024 09:35
…ridgroup#1213)

contrib/face: BasicFaceRecognizer + EigenFaceRecognizer + FisherFaceRecognizer
Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
@deadprogram
Copy link
Member

Hello @diegohce please take a look at my changes from yesterday to the CI tests now in the dev branch.

And let me know if you want my help on the testing for this PR.

Thank you!

@diegohce
Copy link
Contributor Author

diegohce commented Sep 10, 2024

Hello @diegohce please take a look at my changes from yesterday to the CI tests now in the dev branch.

And let me know if you want my help on the testing for this PR.

Thank you!

What I don't know for the windows CI to run properly is: what's gocv's root path?
because there's where this caffe model files should be unzziped.

@deadprogram
Copy link
Member

Hello @diegohce looks like something off about this PR with a bunch of extra commits? The core commits of the PR itself seem pretty good.

What do you think? git cherry-pick on a new branch off of dev maybe?

@diegohce
Copy link
Contributor Author

Hello @diegohce looks like something off about this PR with a bunch of extra commits? The core commits of the PR itself seem pretty good.

What do you think? git cherry-pick on a new branch off of dev maybe?

@deadprogram I will close this PR and send a cleaner one.

@diegohce diegohce closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants