Filestorage roadmap

[diegohce]

clean commits

[deadprogram]

Thank you very much for the cleanup here @diegohce

Now we probably just need to figure out the permissions on Windows for file writing. Excellent progress, I will try to take a look sometime today.

[deadprogram]

Please note I changed the branch for this PR to dev. 😸

[diegohce]

Please note I changed the branch for this PR to dev. 😸

Did I mistake the branch... again! ?

[diegohce]

Damn! I'm so eager for this to get to the new release!

[diegohce]

Would "/tmp" be a factible directory?

…

On Wed, Aug 28, 2024 at 4:44 AM Ron Evans ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In persistence_test.go <#1208 (comment)>: > @@ -0,0 +1,54 @@ +package gocv + +import ( + "testing" +) + +func TestFileStorage(t *testing.T) { + + fs := NewFileStorageWithParams("testdata/filestorage", FileStorageModeWrite|FileStorageModeFormatJson, "utf-8") Perhaps writing the file into a temp directory would be better and would pass on Windows? Untested: pth := filepath.Join(os.TempDir(), "filestorage.json")fs := NewFileStorageWithParams(pth, FileStorageModeWrite|FileStorageModeFormatJson, "utf-8") — Reply to this email directly, view it on GitHub <#1208 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJCC6H6F3O7VOTIW6P5R73ZTV5XRAVCNFSM6AAAAABNFF2CQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRVGQZDONZYGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[diegohce]

sorry, I missed your code sample. I will try with that right now

…

On Wed, Aug 28, 2024 at 5:10 PM Diego Cena ***@***.***> wrote: Would "/tmp" be a factible directory? On Wed, Aug 28, 2024 at 4:44 AM Ron Evans ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In persistence_test.go > <#1208 (comment)>: > > > @@ -0,0 +1,54 @@ > +package gocv > + > +import ( > + "testing" > +) > + > +func TestFileStorage(t *testing.T) { > + > + fs := NewFileStorageWithParams("testdata/filestorage", FileStorageModeWrite|FileStorageModeFormatJson, "utf-8") > > Perhaps writing the file into a temp directory would be better and would > pass on Windows? > > Untested: > > pth := filepath.Join(os.TempDir(), "filestorage.json")fs := NewFileStorageWithParams(pth, FileStorageModeWrite|FileStorageModeFormatJson, "utf-8") > > — > Reply to this email directly, view it on GitHub > <#1208 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADJCC6H6F3O7VOTIW6P5R73ZTV5XRAVCNFSM6AAAAABNFF2CQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRVGQZDONZYGM> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[deadprogram]

Looking good now @diegohce thank you very much for adding this set of long-needed features! Now squash/merging.