contrib/face: extra setters and getters for LBPHFaceRecognizer #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @diegohce thank you for the addition. Could you please add smoke test for the new functions? See https://github.com/hybridgroup/gocv/blob/release/CONTRIBUTING.md#how-to-add-a-function-from-opencv-to-gocv for details. Thanks! |
|
Hi!
Yes, for sure. Look, I read the contribution doc and the excitement got me.
That's why the las PR do have smoke tests.
Will do today for sure. Thank for taking the time.
Cheers, Diego
…On Wed, Aug 14, 2024, 07:15 Ron Evans ***@***.***> wrote:
Hello @diegohce <https://github.com/diegohce> thank you for the addition.
Could you please add smoke test for the new functions? See
https://github.com/hybridgroup/gocv/blob/release/CONTRIBUTING.md#how-to-add-a-function-from-opencv-to-gocv
for details.
Thanks!
—
Reply to this email directly, view it on GitHub
<#1194 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJCC6HXRUBYEJ6PCWPLRJLZRMU4JAVCNFSM6AAAAABMPCQ6DSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBYGM3TENZTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
❤️ |
Thanks to you! |
deadprogram
force-pushed
the
face-setgrid
branch
from
61220f6
to
66e0add
Compare
deadprogram
changed the title
|
Thank you @diegohce now squashed/merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added some extra getters and setters to LBPHFaceRecognizer I thought might be helpful.
Cheers!