Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color conversion alias #1132

Merged

Conversation

wuhaochen
Copy link
Contributor

Adding some color conversion code alias same as https://github.com/opencv/opencv/blob/850be1e0874a4881b94392773d2f1702344658ac/modules/imgproc/include/opencv2/imgproc.hpp#L536

This change helps with code readability especially for demosaicing.

I left out other alias in the hpp file for now as they seem to be addressing only different naming in YUV format.
The only caveat to this change may be that the String function for ColorConversionCode in https://github.com/hybridgroup/gocv/blob/e2db8f81cfce48d9b2c2d4ce92219a7a4a021bfe/imgproc_colorcodes_string.go can return a different name for a constant, but it should be an ok compromise.

@wuhaochen wuhaochen changed the base branch from release to dev December 12, 2023 16:59
@deadprogram
Copy link
Member

Thank you for the pull request @wuhaochen now merging.

@deadprogram deadprogram merged commit f1e5e40 into hybridgroup:dev Mar 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants