Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for relative horizontal offset #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tanis2000
Copy link

Issue Link 🔗

#339
#218

Goals 🥅

Being able to offset the content view horizontally

Implementation Details ✏️

I added a new case to the Edge enumeration named "relative" that works as a relative offset to the content view

Testing Details 🔍

There is a new demo case in the custom section with this relative offsetting

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #341 (ed0de31) into master (cf1cde7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #341      +/-   ##
=========================================
- Coverage    2.04%   2.01%   -0.04%     
=========================================
  Files          96      96              
  Lines        5472    5562      +90     
=========================================
  Hits          112     112              
- Misses       5360    5450      +90     
Impacted Files Coverage Δ
...EntryKit/Playground/PlaygroundViewController.swift 0.00% <0.00%> (ø)
...tryKit/Presets/PresetsData/PresetsDataSource.swift 0.00% <0.00%> (ø)
.../SwiftEntryKit/Presets/PresetsViewController.swift 0.00% <0.00%> (ø)
Source/Infra/EKContentView.swift 0.00% <0.00%> (ø)
...yAttributes/EKAttributes+PositionConstraints.swift 35.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1cde7...ed0de31. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant