Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend sentence-transformers ONNX test #1734

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Feb 28, 2024

Test that would have catched #1731 & UKPLab/sentence-transformers#2510

This should be merged only by sentence_transformers 2.5.0 (or 2.4.1) release.

Copy link
Collaborator

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fxmarty fxmarty merged commit 23fe6f7 into huggingface:main Mar 18, 2024
47 of 60 checks passed
young-developer pushed a commit to young-developer/optimum that referenced this pull request May 10, 2024
* extend sentence transformers onnx test

* trigger ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants