add vae image processor #1219
Merged
add vae image processor #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
echarlaix
commented
Sep 1, 2023
| @@ -29,6 +29,7 @@ jobs: | |||
| python-version: ${{ matrix.python-version }} | |||
| - name: Install dependencies | |||
| run: | | |||
| pip install git+https://github.com/huggingface/diffusers | |||
There was a problem hiding this comment.
waiting for diffusers next release before we can merge
edit : now comaptible
fxmarty
approved these changes
Sep 4, 2023
| # additional invisible-watermark dependency for SD XL | ||
| from ..pipelines.diffusers.watermark import StableDiffusionXLWatermarker | ||
| if add_watermarker: | ||
| from ..pipelines.diffusers.watermark import StableDiffusionXLWatermarker |
There was a problem hiding this comment.
Could this import be at the top of the file?
There was a problem hiding this comment.
No without making invisible-watermark a hard dependency, I added an additional verification in dd292d8 to check that invisible-watermark is installed if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add an
VaeImageProcessorclass enabling the preprocessing and postprocessing of images pipelines, in which we correctly reshape the inputs as expected by the ONNX model. The watermark is also made optional.