Skip to content

Commit

Permalink
Fix onnx export for transformers>=4.45 (#2054)
Browse files Browse the repository at this point in the history
* fix onnx export for transformers>=4.45

* fix tets

* style
  • Loading branch information
echarlaix authored Oct 11, 2024
1 parent b42db7e commit 9420154
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 5 additions & 1 deletion optimum/exporters/onnx/convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -1128,7 +1128,11 @@ def onnx_export_from_model(

if check_if_transformers_greater("4.44.99"):
misplaced_generation_parameters = model.config._get_non_default_generation_parameters()
if isinstance(model, GenerationMixin) and len(misplaced_generation_parameters) > 0:
if (
isinstance(model, GenerationMixin)
and model.can_generate()
and len(misplaced_generation_parameters) > 0
):
logger.warning(
"Moving the following attributes in the config to the generation config: "
f"{misplaced_generation_parameters}. You are seeing this warning because you've set "
Expand Down
1 change: 1 addition & 0 deletions tests/exporters/onnx/test_exporters_onnx_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ def test_diffusion(self):
check=True,
)

@require_sentence_transformers
def test_sentence_transformers(self):
with TemporaryDirectory() as tmpdirname:
subprocess.run(
Expand Down

0 comments on commit 9420154

Please sign in to comment.