Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGI: update to controller version 1.4.0 & bug fixes #470

Merged
merged 10 commits into from
Feb 8, 2024

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented Feb 8, 2024

What does this PR do?

This updates the base version of the TGI components to 1.4.0 and modifies the Neuron X TGI server accordingly.

This also adds support for the seed parameter during generation.

This also adds python prefill/decode tests and docker integration tests for GPT2 (not included in the CI).

Finally this fixes several bugs that had not been detected yet:

  • apply max_new_tokens in continuous batching (the number of tokens was reset when adding new requests)
  • avoid repeated token in continuous batching (the last token generated before adding a new request was repeated)
  • return correct finish reason (length)
  • correctly handle single token inputs (an error was raised if the input was a single token).

On decode, finished requests were also included.
The last generated token of paused slots was recreated and sent back
instead of generating a new one.
The max_new_tokens was not updated for pending requests while the
generated tokens were now actually seen as input tokens.
This was effectively as if the number of generated tokens had been reset.
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@dacorvo dacorvo marked this pull request as ready for review February 8, 2024 14:09
@dacorvo dacorvo merged commit ab582ce into main Feb 8, 2024
11 checks passed
@dacorvo dacorvo deleted the update_tgi_controller branch February 8, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants