update ckpt conversion flow to use the new sharded ckpt path structure #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbenayoun
approved these changes
Nov 17, 2023
| @@ -38,13 +38,11 @@ def consolidate_tensor_parallel_checkpoints(checkpoint_dir: Union[str, Path]) -> | |||
|
|
|||
| state_dicts = [] | |||
|
|
|||
| for sharded_checkpoint in checkpoint_dir.glob("tp_rank_*"): | |||
| for sharded_checkpoint in sorted(checkpoint_dir.glob("tp_rank_*/checkpoint.pt")): | |||
There was a problem hiding this comment.
This will only work for TP right?
It will need to be updated for TP + PP. That's not an issue, just checking.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
Merging it despite CI failure: CI tokens used to push models to the hub are not available for PR from forks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recent change in neuronx-distributed affected the checkpoint paths/filenames when saving sharded checkpoints.
This PR adjusts Optimum Neuron's checkpoint consolidation code to use the new path/filename structure.