Save / load from checkpoint TP #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
dacorvo
reviewed
Oct 25, 2023
optimum/neuron/distributed/base.py
Outdated
Comment on lines
539
to
540
| is_zero_1_optimizer = optimizer.__class__.__name__ == "NeuronAcceleratedOptimizer" and isinstance(optimizer.optimizer, NeuronZero1Optimizer) | ||
| is_zero_1_optimizer = is_zero_1_optimizer or isinstance(optimizer, NeuronZero1Optimizer) |
There was a problem hiding this comment.
Isn't the check in the first line equivalent to isinstance(optimizer, NeuronAcceleratedOptimizer) ?
Anyway, since in the second line you also accept just NeuronZero1Optimizer, maybe it could be simplified to:
is_zero_1_optimizer = isinstance(optimizer, NeuronZero1Optimizer)
There was a problem hiding this comment.
No because you can have:
- A
NeuronZero1Optimizer, which we do not support yet - A
NeuronAcceleratedOptimizerwhich is a wrapper around the optimizer that is always applied when usingaccelerate(I think we will always fall in that case but I wanted to cover all the cases here). This wrapper contains anoptimizerattribute, and we check if it's aNeuronZero1Optimizer.
dacorvo
reviewed
Oct 26, 2023
dacorvo
approved these changes
Oct 26, 2023
dacorvo
requested changes
Oct 26, 2023
dacorvo
approved these changes
Oct 27, 2023
|
Thank you for fixing this ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.
Fixes: #249