Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stable diffusion export #144

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Fix stable diffusion export #144

merged 4 commits into from
Jul 19, 2023

Conversation

JingyaHuang
Copy link
Collaborator

Fix bugs introduced by the update of the optimum main repo.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dacorvo
Copy link
Collaborator

dacorvo commented Jul 19, 2023

In addition to the usual errors we have, there seems to be an issue with stable diffusion export tests: 'GPT2NeuronConfig' has no attribute 'get_mandatory_axes_for_task'.

@JingyaHuang
Copy link
Collaborator Author

In addition to the usual errors we have, there seems to be an issue with stable diffusion export tests: 'GPT2NeuronConfig' has no attribute 'get_mandatory_axes_for_task'.

@dacorvo, it's interesting as GPT2NeuronConfig is not supposed to be used during the sd test 🤔.

Could you give me a snippet so that I can reproduce it? Thanks!

@dacorvo
Copy link
Collaborator

dacorvo commented Jul 19, 2023

In addition to the usual errors we have, there seems to be an issue with stable diffusion export tests: 'GPT2NeuronConfig' has no attribute 'get_mandatory_axes_for_task'.

@dacorvo, it's interesting as GPT2NeuronConfig is not supposed to be used during the sd test 🤔.

Could you give me a snippet so that I can reproduce it? Thanks!

Yes, my bad, this error is for the next test. The stable diffusion error is about a string passed as a list index.
This is the log from the CI: https://github.com/huggingface/optimum-neuron/actions/runs/5598435281/jobs/10238146802?pr=144.

optimum/exporters/neuron/model_configs.py Outdated Show resolved Hide resolved
optimum/exporters/neuron/model_configs.py Outdated Show resolved Hide resolved
optimum/exporters/neuron/model_configs.py Outdated Show resolved Hide resolved
optimum/exporters/neuron/model_configs.py Show resolved Hide resolved
@JingyaHuang JingyaHuang merged commit 06e222d into main Jul 19, 2023
7 of 12 checks passed
@JingyaHuang JingyaHuang deleted the fix-sd-inf branch July 19, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants