-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rustls-tls-native-roots to allow for OS cert stores for rustls #77
base: main
Are you sure you want to change the base?
Conversation
Lgtm, could you update llm-ls' version in its Cargo.toml to |
I also need to test this, but I did pull down your changes. |
@McPatate just to make sure I did this correctly I saw ya'll were using xtask so I ran a This is all different than what is stated here. So I wanted to make sure that this was fine. However, everything seemed to work. |
Either way, if it works for you this is the same as running |
Well I see that I made a mistake 3 weeks ago when I was writing this comment. it was not debug it was release. However, yeah this seemed to work for me as a fix for the self signed tls certs. I apologize for the delay. |
Let me know if there is anything else needed for this. |
following the discussion in #36 (comment) I realized we can use the rustls-tls-native-roots which says: "Enables TLS functionality provided by rustls, while using root certificates from the rustls-native-certs crate."
The rustls-native-certs "Integration with OS certificate stores for rustls." So it should allow for you to use the root certs from your host. Which should fix our issue from issue #36.