[InferenceClient] Update max_tokens and max_new_tokens default value in docstring
#2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
changed the title
max_tokens and max_new_tokens default value in docstringmax_tokens and max_new_tokens default value in docstring
Wauplin
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Thanks for the update @hanouticelina!
Most likely due to a difference between TGI and transformers at some point. Better to document the TGI default values 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2652.
tiny PR to fix incorrect default value of
max_tokensandmax_new_tokensinInferenceClient.text_generation()andInferenceClient.chat_completion()docstrings, reflecting the default values in text-generation-inference/lib.rs.The default value in
InferenceClient.chat_completion()was incorrectly documented as 20 instead of 100. Themax_new_tokensparameter default value was also added inInferenceClient.text_generation()docstring, given that it's an important generation parameter.