Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n-FR] Translated some files to french #1897 #1900

Open
wants to merge 88 commits into
base: main
Choose a base branch
from

Conversation

JibrilEl
Copy link
Contributor

What is this PR about ?

I translated the following files to french :

  • toctree.yml
  • index.md
  • installation.md
  • hf_file_system.md
  • quick-start.md
  • git_vs_http.md
  • cli.md
  • community.md
  • inference_client.md
  • inference_endpoints.md

What should you check ?

  • Grammar and orthograph
  • If my pull requests follows GitHub/open source contribution good practices (I am a beginner)

@JibrilEl
Copy link
Contributor Author

@Wauplin Created the pull requeste as discussed !

@Wauplin
Copy link
Contributor

Wauplin commented Dec 12, 2023

Thanks a lot @JibrilEl! I will have a look at it soon but it might take a few days given the size of the PR! If you know any French-speaking contributor that would like to review the content, please go ahead to ping them! In any case, I'll also be able to review French.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JibrilEl! I finally started to review your PR. That's a lot of work already! 🤗

I left comments on some files that I reviewed. Before continuing further, could you remove the files that are still in English from this branch. You can keep them in a separate branch if you are working on them. The idea would be to try to have a PR in a good state for review and iterations and not add new files to it (for now).

In addition to the comments below, could you add fr to the github workflow files as done here and here? These are the files that tell GitHub to automatically generate the French version of the docs :)

docs/source/fr/_redirects.yml Outdated Show resolved Hide resolved
docs/source/fr/_toctree.yml Outdated Show resolved Hide resolved
docs/source/fr/_toctree.yml Outdated Show resolved Hide resolved
docs/source/fr/_toctree.yml Outdated Show resolved Hide resolved
docs/source/fr/_toctree.yml Outdated Show resolved Hide resolved
docs/source/fr/installation.md Outdated Show resolved Hide resolved
docs/source/fr/installation.md Outdated Show resolved Hide resolved
docs/source/fr/installation.md Outdated Show resolved Hide resolved
docs/source/fr/installation.md Outdated Show resolved Hide resolved
docs/source/fr/installation.md Outdated Show resolved Hide resolved
JibrilEl and others added 19 commits February 16, 2024 19:11
This reverts commit 34c49a7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants