Add T5-TTS library #965
Add T5-TTS library #965
Conversation
NielsRogge
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
| repoName: "T5-TTS", | ||
| repoUrl: "https://github.com/SWivid/F5-TTS", | ||
| filter: false, | ||
| countDownloads: `path_extension:"safetensors" OR path_extension:"pt"`, |
There was a problem hiding this comment.
Do you know why they went for a solution with both E2_TTS and F5_TTS in the same repo? Doing so doesn't allow for separate counting. If you are in contact with them, would be good to nudge them to split.
The current download rule looks good though, no matter if the models get split in 2 repos are not.
There was a problem hiding this comment.
cc @SWivid would you like to have separate download counts for the E2_TTS and F5_TTS checkpoints?
If yes, then it makes sense to split them up into 2 separate model repositories.
There was a problem hiding this comment.
Would it influences the current spaces using it ?
If not, would like to split it up, otherwise thought it's just OK for having F5 and reproduce E2 there
There was a problem hiding this comment.
Yes so the current Spaces are assuming both are present in the same model repo, see e.g. https://huggingface.co/spaces/mrfakename/E2-F5-TTS/blob/main/app.py#L53.
So updating that would break existing Spaces
There was a problem hiding this comment.
What I would suggest is:
- create a new repo for E2-TTS with E2 checkpoints
- open a PR on https://huggingface.co/spaces/mrfakename/E2-F5-TTS to point to the new repo
- remove the E2-TTS weights from F5-TTS repo
There was a problem hiding this comment.
Agreed! Seperate repos would be better.
There was a problem hiding this comment.
Ok, @SWivid would you be up for that?
There was a problem hiding this comment.
@NielsRogge sorry for the delay, just got repo split and E2 removed from F5 repo.
There was a problem hiding this comment.
Thanks! Note that both model repos would require library_name: f5-tts for downloads to work.
| repoName: "F5-TTS", | ||
| repoUrl: "https://github.com/SWivid/F5-TTS", | ||
| filter: false, | ||
| countDownloads: `path_extension:"safetensors"`, |
There was a problem hiding this comment.
Was it intentional to remove .pt files from the count? IIUC users will download either one or the other but not both, correct?
This PR ensures downloads work for https://huggingface.co/SWivid/F5-TTS.
cc @SWivid