Add SoloAudio as lib for download stats #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangHelin1997
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
Wauplin
reviewed
Sep 18, 2024
Vaibhavs10
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Looks good to me! For later, my recommendation would be to integrate more natively with the Hub and download model checkpoints on-the-fly. Attaching some docs for the integration: https://huggingface.co/docs/huggingface_hub/en/guides/integrations
Thanks again for the PR, I'd let @Wauplin take a final pass and merge! 🤗
Wauplin
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Thanks! And agree with @Vaibhavs10 here about native integration. Let us know if you have any questions :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I want to add the model SoloAudio as a library for download stats. Thanks!
The huggingface repo is https://huggingface.co/westbrook/SoloAudio