-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve prompting for diffusers default snippets #909
Conversation
Addressing comments left on #907, specially for LoRAs
and lint
Co-authored-by: Mishig <[email protected]>
looking great! regarding this line: prompt = "${get_prompt_from_diffusers_model(model) ?? diffusersDefaultPrompt}" I think there can be edge case where user supplied prompt has quote like prompt = "Astronaut holding sign that says "Hello"" # which is that it is now
prompt = "Astronaut holding sign that says \"Hello\"" # which is what it should be |
…/huggingface/huggingface.js into diffusers-prompting-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptually looks great to me! Thanks for taking this to the finish line! 🐐
Co-authored-by: Mishig <[email protected]>
Co-authored-by: Mishig <[email protected]>
Co-authored-by: Mishig <[email protected]>
Co-authored-by: Mishig <[email protected]>
Addressing comments left on #907, specially for LoRAs