Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSR-Speech as lib for download stats #904

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

WangHelin1997
Copy link
Contributor

@WangHelin1997 WangHelin1997 commented Sep 13, 2024

Hi, I want to add the model SSR-Speech as a library for download stats. Thanks!
The huggingface repos are https://huggingface.co/westbrook/SSR-Speech-Mandarin and https://huggingface.co/westbrook/SSR-Speech-English

@julien-c
Copy link
Member

can you update the PR's title and description @WangHelin1997? Thanks!

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WangHelin1997 - Thanks for your PR, as mentioned above please update the Title and add a simple description.

On a quick review, first of all I opened a PR on your English model repo: https://huggingface.co/westbrook/SSR-Speech-English/discussions/1

This PR will make allow the model downloads to be tracked actually, we need the repos to be associated with the tag (in this case ssr-speech) - this will be handy when you release your Mandarin checkpoint as well.

Next, please make sure that the Hub model repo has a well documented README: https://huggingface.co/westbrook/SSR-Speech-English (you can copy information from your github repo as well)

It might be worth adding a model snippet here as well, ref: https://github.com/huggingface/huggingface.js/blob/main/packages/tasks/src/model-libraries-snippets.ts

@WangHelin1997 WangHelin1997 changed the title Update model-libraries.ts Add SSR-Speech to model-libraries.ts Sep 17, 2024
@WangHelin1997 WangHelin1997 changed the title Add SSR-Speech to model-libraries.ts Add SSR-Speech as lib for download stats Sep 17, 2024
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WangHelin1997, thanks for clarifying the PR! I've left a few comments, after that we should be good to merge!

packages/tasks/src/model-libraries.ts Outdated Show resolved Hide resolved
packages/tasks/src/model-libraries.ts Outdated Show resolved Hide resolved
packages/tasks/src/model-libraries.ts Outdated Show resolved Hide resolved
Copy link
Contributor Author

@WangHelin1997 WangHelin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the ssr-speech entry up in the file to keep alphabetical order

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @WangHelin1997! Everything looks good to me now 🤗

I'll let @Vaibhavs10 confirm and merge the PR :)

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for iterating on this! ❤️

@Vaibhavs10 Vaibhavs10 merged commit 4dd127b into huggingface:main Sep 19, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants