-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSR-Speech as lib for download stats #904
Conversation
can you update the PR's title and description @WangHelin1997? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @WangHelin1997 - Thanks for your PR, as mentioned above please update the Title and add a simple description.
On a quick review, first of all I opened a PR on your English model repo: https://huggingface.co/westbrook/SSR-Speech-English/discussions/1
This PR will make allow the model downloads to be tracked actually, we need the repos to be associated with the tag (in this case ssr-speech
) - this will be handy when you release your Mandarin checkpoint as well.
Next, please make sure that the Hub model repo has a well documented README: https://huggingface.co/westbrook/SSR-Speech-English (you can copy information from your github repo as well)
It might be worth adding a model snippet here as well, ref: https://github.com/huggingface/huggingface.js/blob/main/packages/tasks/src/model-libraries-snippets.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @WangHelin1997, thanks for clarifying the PR! I've left a few comments, after that we should be good to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the ssr-speech entry up in the file to keep alphabetical order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @WangHelin1997! Everything looks good to me now 🤗
I'll let @Vaibhavs10 confirm and merge the PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for iterating on this! ❤️
Hi, I want to add the model SSR-Speech as a library for download stats. Thanks!
The huggingface repos are https://huggingface.co/westbrook/SSR-Speech-Mandarin and https://huggingface.co/westbrook/SSR-Speech-English