Add sapiens as a library #900
Conversation
merveenoyan
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
There was a problem hiding this comment.
Look good to me except the download count rule. I saw that there are already 6 models under https://huggingface.co/models?other=sapiens which is nice 👍
| repoName: "sapiens", | ||
| repoUrl: "https://github.com/facebookresearch/sapiens", | ||
| filter: false, | ||
| countDownloads: `path_extension:"pt"`, |
There was a problem hiding this comment.
From what I can see in https://huggingface.co/models?other=sapiens, all models have a config.json file and no .pt files. I think it's best to continue to count downloads using config.json (the default rule) in that case.
Except if the config.json file is not loaded when a onnx file is used and in that case we should count downloads using the onnx downloads instead (but counting config.json would still be preferable if it makes sense)
There was a problem hiding this comment.
The models that are intended to be covered by this PR are these ones. They don't have the tag yet, and they may be split into separate repos (either per-task or per-checkpoint).
There was a problem hiding this comment.
Oh ok, thanks for the pointer 👍
Let's think of a clean up before merging then (maybe contact the other 6 repos to change their tag?)
There was a problem hiding this comment.
cc @xenova. I think the tag is auto-inferred from the configuration (they are sapiens models), but they are ONNX versions.
There was a problem hiding this comment.
So maybe
| countDownloads: `path_extension:"pt"`, | |
| countDownloads: `path_extension:"pt" OR path_extension:"onnx"`, |
would be appropriate to handle both cases. If all of them are sapiens models, that's perfect.
There was a problem hiding this comment.
It seems the extension is a bit flexible:
- .pth: https://huggingface.co/facebook/sapiens-depth-0.3b/tree/main
- .pt2 instead of .pt for the bfloat16 models: https://huggingface.co/facebook/sapiens-pretrain-0.3b-bfloat16/tree/main
There was a problem hiding this comment.
But is https://github.com/facebookresearch/sapiens able to load all of these weights? This doesn't seem very unified 😕
|
they've merged all PRs adding sapiens tag @Wauplin |
No description provided.