Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RTX 2070 SUPER Mobile and RTX 2070 SUPER in hardware.ts #880

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Add support for RTX 2070 SUPER Mobile and RTX 2070 SUPER in hardware.ts #880

merged 3 commits into from
Sep 6, 2024

Conversation

sanjumsanthosh
Copy link
Contributor

Came across https://huggingface.co/settings/local-apps and wanted to add couple more GPUs i had.

This pull request adds FP16 (half) FLOPs for the RTX 2070 SUPER Mobile and RTX 2070 SUPER graphics cards in the hardware.ts file.

Ref

Vaibhavs10
Vaibhavs10 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @sanjumsanthosh for the contribution. This looks good to me. Once @pcuenca give it a review/ approval we can proceed to merge.

btw I had no clue about RTX 2070 SUPER series haha, thanks!

pcuenca
pcuenca approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot! Updating from main for CI.

@pcuenca pcuenca merged commit 7dd9043 into huggingface:main Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coyotte508 coyotte508 coyotte508 approved these changes

@pcuenca pcuenca pcuenca approved these changes

@Vaibhavs10 Vaibhavs10 Vaibhavs10 approved these changes

@osanseviero osanseviero Awaiting requested review from osanseviero osanseviero is a code owner

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanjumsanthosh @coyotte508 @pcuenca @Vaibhavs10