Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks: Add video-text-to-text task page #878

Merged
merged 19 commits into from
Sep 6, 2024
Merged

Conversation

merveenoyan
Copy link
Contributor

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter suggestions

packages/tasks/src/tasks/video-text-to-text/data.ts Outdated Show resolved Hide resolved
packages/tasks/src/tasks/video-text-to-text/data.ts Outdated Show resolved Hide resolved
@merveenoyan
Copy link
Contributor Author

merveenoyan commented Sep 6, 2024

IDK why linting on my local results in no change but here it fails works now

@merveenoyan
Copy link
Contributor Author

I did another passthrough and couldn't see anything that I'd change, would love an approval if there's no other thing y'all would change here

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a final pass and suggested a couple of minor nits, LGTM 🔥

packages/tasks/src/tasks/video-text-to-text/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/video-text-to-text/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/video-text-to-text/about.md Outdated Show resolved Hide resolved
@merveenoyan merveenoyan merged commit f9aa67d into main Sep 6, 2024
5 checks passed
@merveenoyan merveenoyan deleted the add-vt2t-task-page branch September 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants