Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasks: update widget models, model recommendations #876

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Tasks: update widget models, model recommendations #876

merged 10 commits into from
Sep 5, 2024

Conversation

merveenoyan
Copy link
Contributor

Updated widget models and model recommendations and fixed former canonical model and dataset ids.

@merveenoyan merveenoyan marked this pull request as ready for review August 29, 2024 20:51
Vaibhavs10
Vaibhavs10 reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update - reviewed the PR from Audio PoV! 🙇

packages/tasks/src/tasks/audio-classification/data.ts Outdated Show resolved Hide resolved
packages/tasks/src/tasks/audio-classification/data.ts Outdated Show resolved Hide resolved
packages/tasks/src/tasks/audio-to-audio/data.ts Show resolved Hide resolved
packages/tasks/src/tasks/automatic-speech-recognition/data.ts Outdated Show resolved Hide resolved
packages/tasks/src/tasks/text-to-speech/data.ts Show resolved Hide resolved
@merveenoyan
Copy link
Contributor Author

@Vaibhavs10 thanks a lot for the recommendations! I'm pretty uneducated so I had this sort of filtering when ranking models both in trending and likes and activity when doing audio ones

osanseviero
osanseviero reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice update 🔥 please make sure the API works for the widget models

packages/tasks/src/tasks/audio-classification/data.ts Show resolved Hide resolved
packages/tasks/src/tasks/automatic-speech-recognition/data.ts Show resolved Hide resolved
packages/tasks/src/tasks/automatic-speech-recognition/data.ts Show resolved Hide resolved
packages/tasks/src/tasks/document-question-answering/data.ts Outdated Show resolved Hide resolved
packages/tasks/src/tasks/fill-mask/data.ts Show resolved Hide resolved
packages/tasks/src/tasks/sentence-similarity/data.ts Show resolved Hide resolved
packages/tasks/src/tasks/sentence-similarity/data.ts Show resolved Hide resolved
packages/tasks/src/tasks/text-generation/data.ts Outdated Show resolved Hide resolved
packages/tasks/src/tasks/text-to-image/data.ts Show resolved Hide resolved
packages/tasks/src/tasks/translation/data.ts Outdated Show resolved Hide resolved
@Vaibhavs10 Vaibhavs10 mentioned this pull request Sep 3, 2024
Open
pcuenca
pcuenca reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with the comments others made.

@pcuenca
Copy link
Member

pcuenca commented Sep 4, 2024 •
edited
Loading

Fixed the conflict, applied the description changes from #867. This touches a lot of files, let's try to add the remaining comments and merge soon @merveenoyan 😄

@merveenoyan
Copy link
Contributor Author

@pcuenca I think I addressed all comments but forgot to resolve, there shouldn't be any other comments

pcuenca
pcuenca approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought Tom's comment had not been applied but it was. I assume Omar's ones have been addressed too.

Merged again to pull the CI fixes, LGTM!

@pcuenca
Copy link
Member

pcuenca commented Sep 5, 2024

Merging these updates.

@pcuenca pcuenca merged commit a087416 into main Sep 5, 2024
5 checks passed
@pcuenca pcuenca deleted the update-models branch September 5, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osanseviero osanseviero osanseviero left review comments

@Vaibhavs10 Vaibhavs10 Vaibhavs10 left review comments

@tomaarsen tomaarsen tomaarsen left review comments

@pcuenca pcuenca pcuenca approved these changes

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@merveenoyan @pcuenca @osanseviero @Vaibhavs10 @tomaarsen