Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ollama #687

Merged
merged 12 commits into from
Oct 16, 2024
Merged

Add ollama #687

merged 12 commits into from
Oct 16, 2024

Conversation

boxabirds
Copy link
Contributor

Very popular local LLM inference server.

@osanseviero
Copy link
Contributor

Thanks for the PR! Unfortunately, I don't think this would work as ollama re-hosts the models themselves. E.g. an example url generated by your PR is https://ollama.com/library/meta-llama/Meta-Llama-3-8B which is a 404 on ollama

@boxabirds
Copy link
Contributor Author

boxabirds commented May 20, 2024 via email

@osanseviero
Copy link
Contributor

The only goal of this button is to work with deeplinks. The button serves no other purpose

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @boxabirds - Just a heads-up we are thinking about this a bit more in our current sprint. We might have some exciting updates soon! 🤗

@julien-c
Copy link
Member

i thinik we could revive this PR but switch to a copy-pasteable command (like llama.cpp) rather than a deeplink

@julien-c
Copy link
Member

@boxabirds ok for you if @mishig25 from our team takes over your PR and completes it?

Very popular local LLM inference server.
@mishig25 mishig25 mentioned this pull request Oct 16, 2024
3 tasks
@mishig25
Copy link
Collaborator

mishig25 commented Oct 16, 2024

Ready to be reviewed

Order of operations

@@ -389,6 +399,13 @@ export const LOCAL_APPS = {
displayOnModelPage: (model) => model.library_name === "diffusers" && model.pipeline_tag === "text-to-image",
deeplink: (model) => new URL(`https://models.invoke.ai/huggingface/${model.id}`),
},
ollama: {
prettyLabel: "Ollama",
docsUrl: "https://ollama.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably have dedicated docs on the hub for this, but we can make a follow-up PR later on

packages/tasks/src/local-apps.ts Show resolved Hide resolved
mishig25 added a commit that referenced this pull request Oct 16, 2024
Moving this function from moon to hf.js/gguf as I need it for
#687

```ts
const quantLabel = parseGGUFQuantLabel("abc-Q4.gguf")
console.log(quantLabel)
// Q4
```

### Order of operations
- [ ] merge #967 (this
PR) & deploy `@hf.js/gguf`
- [ ] merge #687 &
deploy `@hf.js/tasks`
- [ ] merge moon

---------

Co-authored-by: Xuan Son Nguyen <[email protected]>
Co-authored-by: Julien Chaumond <[email protected]>
@mishig25
Copy link
Collaborator

@coyotte508 could you help me with correctly importing hfjs/gguf inside hfjs/tasks?
I did acae236 & b34e76b with command

cd packages/tasks
pnpm add @huggingface/gguf@workspace:^

However, the tests are failing & huggingface/gguf is not visible inside huggingface/tasks

@coyotte508
Copy link
Member

coyotte508 commented Oct 16, 2024

@coyotte508 could you help me with correctly importing hfjs/gguf inside hfjs/tasks? I did acae236 & b34e76b with command

cd packages/tasks
pnpm add @huggingface/gguf@workspace:^

However, the tests are failing & huggingface/gguf is not visible inside huggingface/tasks

you can add "prepare": "pnpm run build", in gguf/package.json in the "scripts"

(but not thrilled to add a dep to @huggingface/tasks)

Also #887 woudl have fixed it maybe (no need for "prepare" anymore)

@julien-c
Copy link
Member

(but not thrilled to add a dep to @huggingface/tasks)

im guessing we could merge tasks and gguf...

mishig25 added a commit that referenced this pull request Oct 16, 2024
@mishig25 mishig25 merged commit 11b59f5 into huggingface:main Oct 16, 2024
3 of 4 checks passed
@coyotte508 coyotte508 mentioned this pull request Oct 18, 2024
coyotte508 added a commit that referenced this pull request Oct 18, 2024
Follow up to #687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants