-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IFE task page and edit FE task page #559
Merged
merveenoyan
merged 16 commits into
huggingface:main
from
merveenoyan:add_image_feature_ext_task_page
Apr 8, 2024
Merged
Add IFE task page and edit FE task page #559
merveenoyan
merged 16 commits into
huggingface:main
from
merveenoyan:add_image_feature_ext_task_page
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merveenoyan
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin and
julien-c
as code owners
March 15, 2024 17:31
I will lint once the content gets reviewed, edited it from GH UI since I have plenty of things on my local 🫠 |
osanseviero
requested review from
pcuenca
and removed request for
julien-c,
gary149,
Wauplin and
SBrandeis
March 18, 2024 09:14
osanseviero
reviewed
Mar 18, 2024
pcuenca
reviewed
Mar 18, 2024
osanseviero
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Let's wait for Pedro's review to have a second pair of eyes
osanseviero
reviewed
Mar 26, 2024
Co-authored-by: Omar Sanseviero <[email protected]>
pcuenca
approved these changes
Mar 26, 2024
test doesn't seem related to this branch, can I merge this? @coyotte508 |
yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.