Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy-from-env feature to ureq crate #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liutaon
Copy link

@liutaon liutaon commented Feb 4, 2024

The asynchronous version of hf-hub automatically enables proxy support based on environment variables by default, whereas the synchronous version does not. To ensure consistency between the two, it is necessary for the synchronous version to also adopt this behavior.

@GitNiko
Copy link

GitNiko commented Feb 23, 2024

Currently, the only way to implement this fix is to make code changes in the local repository before the maintainer merges this PR

hf-hub = { path = "/path/to/hf-hub", features = ["tokio"] }

@liutaon liutaon force-pushed the add-proxy-from-env-feature branch from 860d469 to 40229a9 Compare May 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants