Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin fsspec < 2023.9.0 #6214

Closed
albertvillanova opened this issue Sep 5, 2023 · 0 comments · Fixed by #6244
Closed

Unpin fsspec < 2023.9.0 #6214

albertvillanova opened this issue Sep 5, 2023 · 0 comments · Fixed by #6244
Assignees
@mariosasko
Labels
enhancement New feature or request

Comments

@albertvillanova
Copy link
Member

albertvillanova commented Sep 5, 2023 •
edited
Loading

Once root issue is fixed, remove temporary pin of fsspec < 2023.9.0 introduced by:

Related to issue:

After investigation, I think the root issue is related to the new glob behavior with double asterisk ** they have introduced in:
@albertvillanova albertvillanova added the enhancement New feature or request label Sep 5, 2023
@mariosasko mariosasko self-assigned this Sep 15, 2023
@mariosasko mariosasko mentioned this issue Sep 15, 2023
Merged
JalinWang added a commit to JalinWang/filesystem_spec that referenced this issue Mar 15, 2024
@JalinWang
add a prevailing library user
e69b66c 
I inadvertently found out that the data tool of the most popular Deep Learning/Transformer library also relies on `fsspec` and I think its popularity deserves this PR :)

huggingface/datasets#6214
https://github.com/search?q=repo%3Ahuggingface%2Fdatasets%20fsspec&type=code
This was referenced Mar 15, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariosasko mariosasko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for fsspec>=2023.9.0 huggingface/datasets
2 participants
@albertvillanova @mariosasko