Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add a Prevailing Library User #1545

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

JalinWang
Copy link
Contributor

@JalinWang JalinWang commented Mar 15, 2024

I unexpectedly discovered that the data tool of the most popular Deep Learning/Transformer library also relies on fsspec, and given its widespread popularity, I believe it would be worthwhile to contribute a pull request (PR) for it :)

huggingface/datasets#6214
https://github.com/search?q=repo%3Ahuggingface%2Fdatasets%20fsspec&type=code

I inadvertently found out that the data tool of the most popular Deep Learning/Transformer library also relies on `fsspec` and I think its popularity deserves this PR :)

huggingface/datasets#6214
https://github.com/search?q=repo%3Ahuggingface%2Fdatasets%20fsspec&type=code
@martindurant
Copy link
Member

Huggingface doesn't just use fsspec, but has a dedicated implementation, as listed here: https://filesystem-spec.readthedocs.io/en/latest/api.html#other-known-implementations .

Do you think that's not prominent enough?

@JalinWang
Copy link
Contributor Author

JalinWang commented Apr 2, 2024

Apologies for the delay in response.

I raised this pull request from the perspective of a new user. As a newcomer, I only glanced through the documentation index page to understand its overall functionality/popularity, and assess its reliability for potential usage in my current or future projects. It's unlikely for newcomers to delve deeply into the documentation, navigate to the API page, and scroll through half of it to find the "Other Known Implementations" entry, especially considering they are the ones who need the "Who uses fsspec?" section the most to know that this library is backed by other popular projects :(

I believe it would be helpful to at least link Other Known Implementations in the Who uses fsspec? section.
Additionally, considering the popularity of the Hugging Face repository (e.g., currently ranked #30 according to a Gitstar Ranking), I don't see an issue with mentioning it twice in the documentation, similar to how the DVC repository is presented.

image

@martindurant
Copy link
Member

Sure, your suggestion is fine - can you please add a "see known implementations" link too, then? Probably the who-uses section hasn't been updated in a long time, and a lot of improvements could be made.

@martindurant martindurant merged commit 926ec19 into fsspec:master Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants