-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation into Russian - first PR #93
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@merveenoyan @stevhliu Hello, have a good day) A few questions:
|
@stevhliu Hello Steven. Can you please tell me who can do a review? |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@stevhliu Greate Thanks. But i dont see Russian in docs PR preview: And I dont undestand why? |
@stevhliu I think I found the problem: I have not added the language code to the documentation build files (YAML files). |
@stevhliu How we can rebuild doc preview? |
@stevhliu @merveenoyan Hello. HuggingFaceDocBuilderDev still does not show RU in preview. I've made all the necessary edits, but it just doesn't seem to be rebuilding the documentation. How do I initiate a rebuild of the preview? If of course I can do that. |
It should work now :) |
@stevhliu @merveenoyan Good day. Anyway, I haven't found anyone who could do a review for Russian. I made it myself - by myself. Can I run the documentation preview build again? I want to see how the edits I made will look like. |
@stevhliu @merveenoyan Good evening. Checked out the previews. Looks and reads good. We can merge. |
I can help with the review (my native language is Russian). For other languages I can help with formatting and other small things like that. But I have never done it before. But I think - I will learn, the main thing is to try). |
Thanks for your translation, we appreciate your effort and work! However, to ensure the Cookbook's quality, we really should have a review from someone else who can also read Russian just to ensure there are no typos and it translates well. Hope you understand! 🤗 |
This is the first PR translation of the cookbook into Russian.
Any native speaker from the HF team can do the review. An earlier review was done by @MKhalusova.