Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actual preview to Export Map Stitch Image #619

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

GriffinRichards
Copy link
Collaborator

@GriffinRichards GriffinRichards commented Oct 2, 2024

Closes #499

Addresses confusion about what the "Stitch Image" feature does by displaying an actual preview of the image that will be created. The image can obviously be quite large, so the preview will now scale to fit the view. The original behavior for the preview (showing the image at the normal scale for the map editor) is preserved with a "Preview actual size" setting.

Also adds a brief description at the top of the window describing what the current image exporter will do.

Changing settings (which recreates the preview) is now likely to be significantly slower for most stitch images. I think this is a fine trade-off, having a real preview is valuable and I don't think toggling a bunch of settings is the main use case here.

(Final note, the diff in the form is mostly QtCreator relocating things. Aside from the label there were only some minor changes to give the preview more space)

UPDATE: Added an All setting for events so if someone wants to toggle on all the event settings for a stitch map they don't need to wait for it to update 5 times. Also noticed an unrelated bug that I'll fix later (the map connections used for the image export are the connections for the map in the editor -- which can change -- not the map in the export window).

preview

@GriffinRichards GriffinRichards merged commit 426fadd into huderlem:master Oct 10, 2024
3 checks passed
@GriffinRichards GriffinRichards deleted the stitch-preview branch October 10, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make functionality of "Export Map Stitch Image" clearer
1 participant