Add graceful shutdown and error handling #779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently not functional due to switch not working
|
Ready for review. |
thornjad
requested changes
May 31, 2022
bin/http-server
Outdated
| @@ -60,12 +64,15 @@ if (argv.h || argv.help) { | |||
| ' --no-dotfiles Do not show dotfiles', | |||
| ' --mimetypes Path to a .types file for custom mimetype definition', | |||
| ' -h --help Print this list and exit.', | |||
| ' -v --version Print the version and exit.' | |||
| ' -v --version Print the version and exit.', | |||
| ' -n --no-panic If error occurs, gracefully shut down and create log file', | |||
There was a problem hiding this comment.
I'm not sure -n is an easy mnemonic here, would only having the long version available be sufficient?
bin/http-server
Outdated
| let etime = new Date().toISOString().replace(/T/, ' ').replace(/\..+/, '') | ||
| console.log(colors.green(etime)) | ||
| console.log(colors.red("Fatal error: ")+ e.code + ": "+e.message) | ||
| let fname = ".httpserver-"+etime.split(" ")[0]+"-"+etime.split(" ")[1] |
There was a problem hiding this comment.
For the log file, could we end it with .log to make it clear what the file is?
Co-authored-by: Jade Michael Thornton <[email protected]>
zbynek
suggested changes
Jun 11, 2022
| @@ -57,6 +57,10 @@ Default file extension is none is provided. | |||
| .BI \-s ", " \-\-silent | |||
| Suppress log messages from output. | |||
|
|
|||
| .TP | |||
| .BI \-n ", " \-\-no-panic | |||
| var argv = require('minimist')(process.argv.slice(2), { | ||
| alias: { | ||
| tls: 'ssl' | ||
| } | ||
| }); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling for fatal crashes of any type. Just so you don't have to see a giant error stack on your console.
The feature is turned on by the
--no-panicoption or by the environment variable NODE_HTTP_SERVER_NO_PANIC.The output is something like:
Relevant issues
Refers partly to #665
What needs to be done:
Contributor checklist
--helpoutputmasterbranchMaintainer checklist