Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert video tags to links #104

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Convert video tags to links #104

wants to merge 6 commits into from

Commits on Aug 11, 2016

  1. Convert <video> tags to links 

    Don't strip out `<video>` tags completely, rather convert
them to bracketed links like is done for images.

Relates to html-to-text#103
    @evanrmurphy
    evanrmurphy committed Aug 11, 2016
    Configuration menu
    Copy the full SHA
    721c913 View commit details
    Browse the repository at this point in the history

  2. Add ignoreVideo option 

    Also correct spacing (tabs, not spaces) in `formatVideo` function.
    @evanrmurphy
    evanrmurphy committed Aug 11, 2016
    Configuration menu
    Copy the full SHA
    c18914c View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2016

  1. Don't check for alt attribute on video tags 

    `video` tags don't have `alt` attributes.
    @evanrmurphy
    evanrmurphy committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    4507139 View commit details
    Browse the repository at this point in the history

  2. Recognize videos with source tag 

    Before only recognized `video` tags with a `src` attribute. Now
if no `src` attribute is found, check for a `source` child element.
    @evanrmurphy
    evanrmurphy committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    978df3c View commit details
    Browse the repository at this point in the history

  3. Update examples/test.html with image a video examples

    @evanrmurphy
    evanrmurphy committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    52f1748 View commit details
    Browse the repository at this point in the history

  4. Use file extensions in image and video examples

    @evanrmurphy
    evanrmurphy committed Aug 12, 2016
    Configuration menu
    Copy the full SHA
    3216799 View commit details
    Browse the repository at this point in the history