-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streaming CSV processing/plotting #27
Conversation
Conflicts: build/app.js
@breznak - I ran a test of this, and it did not seem to work. When I tried to load a file nothing happens, and I got a lot of stuff logged to the console. |
I'm not sure what changed (broken merge, the newer libs) but I'm getting this error too. Will try to investigate. |
Conflicts: build/app.js client/src/app/appCtrl.js
This needs some more love, but I got it working.
When ready, this could be a good way to #17 |
@jefffohl @rhyolight can you take a look at c2c14a7 please? I want to load a small(er) batch, render it quickly, repeate. |
@breznak You can update the graph data by calling the I can start working on this if you would like - but I don't want to work in parallel with you - so let me know. |
FYI - here is the Dygraphs API reference: http://dygraphs.com/jsdoc/symbols/Dygraph.html |
That would be great @jefffohl ! I'll take a break and sleep now :) |
@breznak - I started on this today, but didn't get too far yet. I will work on it again tomorrow, unless you are eager to jump back in. If so - let me know. |
@breznak - due to requests from @rhyolight i am prioritizing #40. i still plan on working on this though. let me know your thoughts. |
…s. Note that this does not yet allow for streamed files over HTTP.
Fixes #26. Chunked streaming in PapaParse
Conflicts: build/app.js
…y/nupic.visualizations into speedup_csv_parse Conflicts: build/app.js client/src/app/appCtrl.js
@jefffohl thanks for #54 (you made a PR to merge into this PR, not master, which confused me..sorry.) Anyway, this is your work from #54.
|
@breznak - ok, taking a look. |
@breznak - this is happening only for files without a timestamp. Working on a fix. One other thing I noticed with very large files is that there is a limit as to what DyGraphs can handle. My system locked up trying to render the 60MB file. For files this large, it seems we will need to figure out a way to enforce windowing or something. |
Thanks @jefffohl ! I've noticed another thing, when the
|
I made a new PR to the speedup_csv_parse branch from my version of that branch, which fixes the problem of series without timestamps overwriting the iteration value. |
Addresses #26. Fixes problem of files that have no timestamp.
@breznak - I am going to merge this into master, if that is OK with you. For your recent comments regarding enforced windowing, and monotonic alerts, lets make some new issues for those. |
Streaming CSV processing/plotting
Thank you Jeff! merged the branch and I'll make the issues. |
Fixes #26