HTCONDOR-2193 gpu-reqs #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Condor-C jobs won't have this check added automatically and startds that don't have GPU detection won't include a check. If we don't add a check here, then jobs with RequestGPUs set can end up running on machines with no GPUs when routed to a local HTCondor pool. We only set Requirements if it's currently the literal value 'true'. We expect newer clients to start setting all of the automatic requirements clauses for Condor-C jobs, and we don't want to ignore those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condor-C jobs won't have this check added automatically and startds that don't have GPU detection won't include a check. If we don't add a check here, then jobs with RequestGPUs set can end up running on machines with no GPUs when routed to a local HTCondor pool.
We only set Requirements if it's currently the literal value 'true'. We expect newer clients to start setting all of the automatic requirements clauses for Condor-C jobs, and we don't want to ignore those.