Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

http-circe: scala 3 #838

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gabriele83
Copy link

  • added scale 3 support for http circe library
  • fixed implicit resolution error on circe tests

Gabriele Favaretto added 2 commits November 24, 2023 16:44
- update scala 3 vesrion: 3.3.1
- cross building: akka-http-circe
- removed redundant 'final' modifier
- updated dependencies

fix
@@ -102,7 +102,7 @@ trait ZioJsonSupport {
Unmarshaller(_ =>
bs => {
val decoded = jd.decodeJsonStreamInput(ZStream.fromIterable(bs))
Unsafe.unsafeCompat(implicit u => rt.unsafe.runToFuture(decoded))
Unsafe.unsafe(implicit u => rt.unsafe.runToFuture(decoded))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabriele83 I'm interested in using your changes in https://github.com/pjfanning/pekko-http-json.

Could you help by explaining why this ZIO change is useful? The rest of the PR is about Circe but I'd like to apply this change to pekko-http too if it is an improvement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants