Fix11k

[sheetalk]

No description provided.

[hrjet]

Can one of the admins verify this patch?

[hrj]

ok to test

[hrj]

add sheetalk to whitelist

[hrj]

destination will be always one. Hence it should not be a list.

[hrj]

Not sure why you need this abstract class. If not required, plz remove it.

[hrj]

Important: You need to check for an error condition: If the same account is present in more than one closure source, then it is an error.

For example,

closures += {
  sources = "Income"
  destination = "xyz"
}

closures += {
  sources = "Income"
  destination = "xyz"
}

should throw an error, because Income will be matched twice!

[hrj]

retest this please

[hrj]

you are calling closureEntries.head, which will only export the first closure.
What about the remaining closures?

[sheetalk]

Sir,Can you tell me,Which comment I have not solved ???
According to me,I am Done.

[hrj]

This one I have not solved.As 'config' is not returning list of 'closures'.

You can solve it by writing a unit test case for it. In the test cases we are not using the config library.

[sheetalk]

"

Important: You need to check for an error condition: If the same account is present in more than one closure source, then it is an error.

For example,

closures += {
sources = "Income"
destination = "xyz"
}

closures += {
sources = "Income"
destination = "xyz"
}

should throw an error, because Income will be matched twice!

"This one I have not solved.As 'config' is not returning list of 'closures'.

[sheetalk]

Sir,
I have added unit test case.It is throwing exception if 'source' in closure contains duplicate 'accountName'.

[hrj]

good, now you have to modify the testcase to handle the exception.

See this tip: http://alvinalexander.com/scala/scalatest-testing-expected-exceptions-intercept-testfailedexception

[sheetalk]

Done

[hrj]

You are modifying a var inside a map application. Remember map should not have side-effects.

I suggest you separate out the check for sourceNames into a separate function and use foreach whenever you need a side-effect.

[sheetalk]

Sir,
I have separated sourceNames into a separate function
Please check

[hrj]

I have separated sourceNames into a separate function

Thanks for the effort. The way you have defined the new function is not ideal. But explaining over email is difficult. I will make some changes directly, squash the commits and push directly to master.

[sheetalk]

k sir

[hrj]

Superceded by #39