Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print NA states #15

Merged
merged 3 commits into from
Aug 25, 2018
Merged

Print NA states #15

merged 3 commits into from
Aug 25, 2018

Conversation

mkiang
Copy link
Contributor

@mkiang mkiang commented Apr 11, 2018

Addresses #14 but I haven't tested it very thoroughly and requires the user to specify an NA label, but it might be preferable to do it another way...

@hrbrmstr hrbrmstr self-assigned this Apr 11, 2018
@hrbrmstr
Copy link
Owner

#ty! I'll take a look at it (likely in the early AM tomorrow). Could you also update the DESCRIPTION file and add yourself as a contributor?

@mkiang
Copy link
Contributor Author

mkiang commented Apr 12, 2018

Sure. I updated to try to match your style guide and added myself to the DESCRIPTION but given the minor nature of the edit, I'm happy with an uncredited PR. Thanks for the package — hoping to use it on a publicly-available conference presentation this month.

@mkiang
Copy link
Contributor Author

mkiang commented Apr 12, 2018

Realized I didn't modify the geom. Did so and here is some sample code to make sure it works:

library(statebins)
library(dplyr)
library(ggplot2)
data(USArrests)

USArrests$state <- rownames(USArrests)
USArrests$Assault[1:4] <- NA

statebins(USArrests, value_col="Assault", name = "Assault", round=TRUE) +
    theme_statebins(legend_position="right")

ggplot(USArrests, aes(state = state, fill = Assault)) + 
    geom_statebins() + 
    theme_statebins(legend_position="right") + 
    coord_equal()

@hrbrmstr hrbrmstr merged commit 200f4d9 into hrbrmstr:master Aug 25, 2018
hrbrmstr added a commit that referenced this pull request Jul 30, 2019
hrbrmstr added a commit that referenced this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants