Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Dependencies #361

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

itsMikey
Copy link

@itsMikey itsMikey commented Feb 2, 2021

Update project dependencies

Description

Electron-settings has an updated API. Changed any calls to get, set, has to getSync, setSync, hasSync respectfully because the old calls are now async and the code relies on these calls in a synchronous fashion.

  • Updated electron and had to update any initialized BrowserWindow instances to support running in a node environment. When we initialize a browser window, we now have to include the following:
webPreferences: {
      nodeIntegration: true,
      enableRemoteModule: true,
  }	
  • duplicate-package-checker-webpack-plugin is no longer maintained, switched to @cerner/duplicate-package-checker-webpack-plugin which is currently being maintained

  • Updated moment and changed any calls of .lang to the updated .locale

  • Updated webpack to V5 which has a few changes in their API.

Related Issue

#359 #348

Motivation and Context

This is an amazing app and it has helped many of us in our daily lives. A lot of the dependencies used are out of date, some are not maintained anymore (duplicate package checker) and a lot of the API's have changed since this was last updated and I also had to use a much older version of Node to get this running. There's a lot of discussion about how this project is unmaintained and I thought I'd do my part by updating the dependencies and bringing this project up to date. Alas, I hope this will invite people to hop on in and we can all maintain this as a community.

How Has This Been Tested?

No logic has changed but the API of some dependencies (electron-settings, moment) has changed a bit. Existing tests still pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have included a migration scheme (If type of change is breaking change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant