Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mixed read/write raw workloads #165

Open
lawben opened this issue Jan 21, 2022 · 0 comments
Open

Remove mixed read/write raw workloads #165

lawben opened this issue Jan 21, 2022 · 0 comments

Comments

@lawben
Copy link
Member

lawben commented Jan 21, 2022

This does not really make sense and the numbers are hard to interpret.
This was referenced Jan 22, 2022
Open
Merged
lawben added a commit that referenced this issue Jan 25, 2022
@lawben
Clean up BenchmarkConfig (#168)
62c5ce2 
This PR does a lot of random clean ups.

The core changes are:
 - moved `BenchmarkConfig` to its own file
 - changed `write_ratio` to `operation`, with `Operation::Read` and `Operation::Write` (a pre-step of #165)
 - moved all utils into a `perma::utils` namespace
 - removed the `internal::` namespace, because it was annoying

There is basically no change in logic in this PR and the large file changes are just copy-paste from one to another location. So this can more or less just be skimmed to check for small mistakes. I'll check this myself again on Monday to have a small break before reviewing it again.  

This PR is based on #166, so that needs to be merged first. Overall, these are quite a few substantial refactorings, but hopefully we'll only need one or two PRs more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lawben